Triggering DAG with parameters is mandatory when show_trigger_form_if_no_params is enabled

[csp33]

Apache Airflow version

2.8.0

If "Other Airflow 2 version" selected, which one?

No response

What happened?

When setting show_trigger_form_if_no_params to True, users can not trigger DAGs without configuration. The Trigger DAG button redirects to the Trigger DAG form instead of triggering the DAG with dagrun_conf={} (like before)

Grabacion.de.pantalla.2024-01-17.a.las.13.54.15.mov

What you think should happen instead?

The Trigger DAG button should trigger the DAG with dagrun_conf={} (like before).
The Trigger DAG w/ config button should keep its behavior.

How to reproduce

1. Add a DAG without params to your DAGs folder (for example, example_bash_operator.py).
2. Start Airflow with the following environment variable value: AIRFLOW__WEBSERVER__SHOW_TRIGGER_FORM_IF_NO_PARAMS=True
3. Try to trigger the DAG without config (first option)

Operating System

Airflow Docker Image

Versions of Apache Airflow Providers

No response

Deployment

Official Apache Airflow Helm Chart

Deployment details

AIRFLOW__WEBSERVER__SHOW_TRIGGER_FORM_IF_NO_PARAMS=True

Anything else?

No response

Are you willing to submit PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[anudeep-pv]

I may be wrong but I think it's related to this change https://github.com/apache/airflow/pull/36026/files#diff-917b70d2661fae8322c538a4f60b9d4ba755556036fe0c527eb0411a6ac60f2e

In this case,
request_conf is None, request.method is POST, show_trigger_form_if_no_params is True
cc: @jscheffl

[jscheffl]

Good catch. It seems this slipped through the tests when we tried to fix the XSS problem of the trigger with the referenced commit.
Also this bug is in 2.8.1. If nobody jumps on this, I could try to fix this in the next weeks.

[jscheffl]

Hi, You need to set it as described here: https://airflow.apache.org/docs/apache-airflow/stable/configurations-ref.html#show-trigger-form-if-no-params Either in airflow.cfg, section webserver or via ENV before starting webserver. Mit freundlichen Grüßen / Best regards Jens Scheffler Alliance: Enabler - Tech Lead (XC-AS/EAE-ADA-T) Robert Bosch GmbH | Hessbruehlstraße 21 | 70565 Stuttgart-Vaihingen | GERMANY | www.bosch.com<http://www.bosch.com/> Tel. +49 711 811-91508 | Mobil +49 160 90417410 | ***@***.******@***.***> Sitz: Stuttgart, Registergericht: Amtsgericht Stuttgart, HRB 14000; Aufsichtsratsvorsitzender: Prof. Dr. Stefan Asenkerschbaumer; Geschäftsführung: Dr. Stefan Hartung, Dr. Christian Fischer, Dr. Markus Forschner, Stefan Grosch, Dr. Markus Heyn, Dr. Tanja Rückert ​ From: wilk85 ***@***.***> Sent: Donnerstag, 1. Februar 2024 11:54 To: apache/airflow ***@***.***> Cc: Scheffler Jens (XC-AS/EAE-ADA-T) ***@***.***>; Mention ***@***.***> Subject: Re: [apache/airflow] Triggering DAG with parameters is mandatory when show_trigger_form_if_no_params is enabled (Issue #36843) Hello, where i need to set show_trigger_form_if_no_params? and also i have no trigger with config in 2.7.3 enveironment varaible AIRFLOW__WEBSERVER__SHOW_TRIGGER_FORM_IF_NO_PARAMS as True is not helping — Reply to this email directly, view it on GitHub<#36843 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWVTFDISNJTZM42DLQCHYHLYRNX3FAVCNFSM6AAAAABB6P76K2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRRGA2DONZWHE>. You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>

[wilk85]

@jscheffl thank you, im using helm charts, and i was wondering which annotation would be right and where exactly to add that env variable, i was testing with env: envVars, extraEnvVars

[jscheffl]

@jscheffl thank you, im using helm charts, and i was wondering which annotation would be right and where exactly to add that env variable, i was testing with env: envVars, extraEnvVars

@wilk85
Please take a look to https://airflow.apache.org/docs/helm-chart/stable/airflow-configuration.html
Probably (never tried myself) you need to set the following in your values.yaml:

config:
  webserver:
    show_trigger_form_if_no_params: 'True'