SECURITY_MANAGER_CLASS not being picked up in webserver_config.py

[CharlieJ15420]

Apache Airflow version

2.8.0

If "Other Airflow 2 version" selected, which one?

No response

What happened?

I've just upgraded from 2.7.3 to 2.8.0 and have my own custom security manager. This custom security manager inherited from AirflowSecurityManager. Now I've upgraded to 2.8.0 I've altered my security manager to inherit from FabAirflowSecurityManagerOverride. Despite this, my custom security manager isn't being picked up. I've made no changes to webserver_config.py where I've specified the SECURITY_MANAGER_CLASS. It should pick up my custom sec manager via this line: https://github.com/apache/airflow/blob/2.8.0/airflow/auth/managers/fab/fab_auth_manager.py#L340 however when I try to login, not only do I get invalid login but the errors in the logs are coming from override.py (where the base FabAirflowSecurityManagerOverride lives) compared to my customsecuritymanager.py. I'm not sure if something else has changed that I need to alter or if there is a bug somewhere that isnt picking up my custom security manager class.

note: I'm also using the default fab auth manager

What you think should happen instead?

My custom security manager should be picked up and used. I've verified it's not being picked up by putting in an incorrect name which in the past has produced an error.

How to reproduce

Try to set your own SECURITY_MANAGER_CLASS in webserver_config.py and inherit from FabAirflowSecurityManagerOverride.

Operating System

CentOS7

Versions of Apache Airflow Providers

No response

Deployment

Official Apache Airflow Helm Chart

Deployment details

No response

Anything else?

No response

Are you willing to submit PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[boring-cyborg]

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

[o-nikolas]

CC @vincbeck

[CharlieJ15420]

Even if I put the entire custom security manager class in webserver_config.py it still doesn't pick it up. I can see webserver_config.py is in the correct dir once deployed too.

[Taragolis]

Is it similar to:

• Webserver fails to start when a class inheriting from FabAirflowSecurityManagerOverride is set to SECURITY_MANAGER_CLASS #36342
• fix inheritance checking of security manager in FabAuthManager #36343

???

[CharlieJ15420]

Not quite, as the webserver starts fine - it's just not picking up my custom security manager at all.

[potiuk]

Can you share your webserver_config.py ? Maybe you have a typo there of some sort ?

[vdozal]

Hi @CharlieJ15420, did you solve this issue? I'm having the same, I added log messages and don't see them, plus I get this message when trying to login:
The request to sign in was denied.

[WRinnovation]

While migrating from 2.4.0 to 2.10.0 I noticed that in the Webserver documentation of 2.8.0 it used SECURITY_MANAGER_CLASS instead of the previous version FAB_SECURITY_MANAGER_CLASS, in addition to using the new class FabAirflowSecurityManagerOverride.

Changing this is what fixed it for me, altough I did not find an official migration guide stating this