Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix inheritance checking of security manager in FabAuthManager #36343

Merged

Conversation

kn3609571
Copy link
Contributor

closes: #36342


  • fix inheritance check of security manager in FabAuthManager

* fix inheritance check of security manager in FabAuthManager
Copy link

boring-cyborg bot commented Dec 21, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@potiuk potiuk added this to the Airflow 2.8.1 milestone Dec 21, 2023
@potiuk
Copy link
Member

potiuk commented Dec 21, 2023

Good one :)

@potiuk potiuk merged commit 2be7149 into apache:main Dec 21, 2023
52 checks passed
Copy link

boring-cyborg bot commented Dec 21, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@kn3609571 kn3609571 deleted the fix-security-manager-inheritance-check branch December 23, 2023 12:18
@kn3609571 kn3609571 restored the fix-security-manager-inheritance-check branch December 23, 2023 12:19
@kn3609571 kn3609571 deleted the fix-security-manager-inheritance-check branch December 23, 2023 12:19
@ephraimbuddy
Copy link
Contributor

Moved this to 2.9.0 since FabAuthManager has been moved to providers cc @vincbeck @potiuk

@potiuk
Copy link
Member

potiuk commented Feb 7, 2024

Moved this to 2.9.0 since FabAuthManager has been moved to providers cc @vincbeck @potiuk

I reassigned it to 2.8.2 as other people are complaining and it's easy to cherry-pick (I will do it)

ephraimbuddy pushed a commit that referenced this pull request Feb 20, 2024
* fix inheritance check of security manager in FabAuthManager

(cherry picked from commit 2be7149)
ephraimbuddy pushed a commit that referenced this pull request Feb 22, 2024
* fix inheritance check of security manager in FabAuthManager

(cherry picked from commit 2be7149)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants