-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
map_index_template not compute when task marked success manually #39092
Comments
This might be fixed by #38902 . It might require adding some logic to render mapped tasks in set_task_instance_state, which I believe is called when manually setting a task instance's state. |
I would like to be assigned this issue. |
@karenbraganz are you still working on this issue ? thanks |
|
I did not re-open it because it looks like the functionality is not viable. The only thing left was for @uranusjr to provide an explanation of why they think it's not viable, which is why I have tagged them here for an explanation. |
could you please tell @RNHTTR if it's okay to unassign you |
Rendering Jinja templates in the webserver means injecting custom user logic into protected Airflow services, which is not acceptable. Rendering must happen in the worker. A fix along the line mentioned in Ryan’s comment above is more likely correct, although I am not sure (and never checked) where exactly the rendering should happen. |
I got the error referenced in my PR after adding my rendering logic to set_task_instance_state() in models/dag.py. I just tried adding the logic to _set_state() (from models/taskinstance.py) which is called by set_task_instance_state() in www/views.py and am getting the same error. I'm not sure how to get the worker to execute the code at the moment, so I will unassign myself. |
Apache Airflow version
2.9.0
What happened?
If i mark a task manually at success while it's running only already succeed mapped task have a
map_index_template
What you think should happen instead?
map_index_template
should be compute in all cases
How to reproduce
trigger a run , wait for a mapped task to succes , then mark state of the task
b
at successAre you willing to submit PR?
Code of Conduct
The text was updated successfully, but these errors were encountered: