Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KubernetesExecutor import is broken in webserver - Airflow 1.10.11 #10015

Closed
wants to merge 2 commits into from
Closed

Fix KubernetesExecutor import is broken in webserver - Airflow 1.10.11 #10015

wants to merge 2 commits into from

Conversation

hienpham2tiki
Copy link

@hienpham2tiki hienpham2tiki commented Jul 27, 2020

Wrong KubernetesExecutor import path causes User can not trigger dag task run in the UI in airflow 1.10.11


Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Jul 27, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 27, 2020

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://apache-airflow-slack.herokuapp.com/

@hienpham2tiki hienpham2tiki changed the title Fix KubernetesExecutor import is broken in webui' Fix KubernetesExecutor import is broken in webserver Jul 27, 2020
@hienpham2tiki hienpham2tiki changed the title Fix KubernetesExecutor import is broken in webserver Fix KubernetesExecutor import is broken in webserver - Airflow 1.10.11 Jul 27, 2020
@hienpham2tiki hienpham2tiki marked this pull request as ready for review July 27, 2020 10:32
@mik-laj
Copy link
Member

mik-laj commented Jul 27, 2020

We have one more problem here. All import paths should be backward compatible. After moving the modules, we should create new modules with references to new locations.
Please look here for an example: https://github.com/apache/airflow/tree/master/airflow/contrib/operators

Your change only partially solves the problem, because other users can still expect KubernetesExecutor in this module and we should handle that too.

@kaxil kaxil added this to the Airflow 1.10.12 milestone Jul 27, 2020
@hienpham2tiki
Copy link
Author

Updated, cc @mik-laj

@dimberman
Copy link
Contributor

#10084 fixed here

@dimberman dimberman closed this Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants