Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre 1.10.11 Kubernetes Paths back with Deprecation Warning #10067

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Jul 30, 2020

The paths were removed without any pending deprecation warning and might break deployments

This PR adds back paths to airflow.contrib.kubernetes


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@kaxil kaxil added this to the Airflow 1.10.12 milestone Jul 30, 2020
@boring-cyborg boring-cyborg bot added the k8s label Jul 30, 2020
Copy link
Contributor

@dimberman dimberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof. First time release managing, thanks for catching this :)

Copy link
Member

@turbaszek turbaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kaxil kaxil merged commit 4f7a453 into apache:v1-10-test Jul 31, 2020
@mik-laj
Copy link
Member

mik-laj commented Aug 1, 2020

@kaxil Can you add entry in UPDATING.md? The entry should explain that in version A we have a breaking change, but in version B it is a non-breaking change.

@uyushkevi
Copy link

@kaxil I see warnings from this PR after installing 1.10.12. Why for example this file https://github.com/apache/airflow/blob/1.10.12/airflow/kubernetes/pod_generator.py has deprecated import?

@kaxil
Copy link
Member Author

kaxil commented Aug 31, 2020

@kaxil I see warnings from this PR after installing 1.10.12. Why for example this file https://github.com/apache/airflow/blob/1.10.12/airflow/kubernetes/pod_generator.py has deprecated import?

That has been fixed and will be available in 1.10.13 --> 7203ca7

@ashb ashb deleted the v1-10-test-k8s-bkp branch December 7, 2020 17:33
@ashb ashb added the provider:cncf-kubernetes Kubernetes provider related issues label Feb 10, 2021
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider:cncf-kubernetes Kubernetes provider related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants