-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pre 1.10.11 Kubernetes Paths back with Deprecation Warning #10067
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oof. First time release managing, thanks for catching this :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@kaxil Can you add entry in UPDATING.md? The entry should explain that in version A we have a breaking change, but in version B it is a non-breaking change. |
@kaxil I see warnings from this PR after installing 1.10.12. Why for example this file https://github.com/apache/airflow/blob/1.10.12/airflow/kubernetes/pod_generator.py has deprecated import? |
That has been fixed and will be available in 1.10.13 --> 7203ca7 |
The paths were removed without any pending deprecation warning and might break deployments
This PR adds back paths to
airflow.contrib.kubernetes
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.