-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update base classes used in bigquery_check_operator to renamed versions #10272
Update base classes used in bigquery_check_operator to renamed versions #10272
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
@dewaldabrie Can you look here? #10271 |
@mik-laj Thanks, I replied there. Not sure why the checks in the CI is failing since it seems related to things I didn't touch like |
We have a bug in the CI cache specification. I am going to fix it shortly |
SHould be fixed now by #10299. I also cherry-picked it to 1-10-stable and 1-10-test. Can you please rebase again on top of the latest v1-10-stable and it should be fixed permanently now. |
Hey @dewaldabrie - if you want this one to be part of 1.10.12 (willl be released very shortly) you should rebase this one |
e262e0e
to
73e1934
Compare
Awesome work, congrats on your first merged pull request! |
Co-authored-by: Dewald Abrie <[email protected]>
Co-authored-by: Dewald Abrie <[email protected]>
…he#10272) Co-authored-by: Dewald Abrie <[email protected]>
airflow.contrib.operators.bigquery_check_operator.BigQueryValueCheckOperator
is derived fromairflow.operators.check_operator.ValueCheckOperator
but needs to be derived fromairflow.operators.sql.SQLValueCheckOperator
instead.Until this is done, airflow generates a lot of warnings from this line of code.
Fixes #10271