Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update base classes used in bigquery_check_operator to renamed versions #10272

Conversation

dewaldabrie
Copy link

@dewaldabrie dewaldabrie commented Aug 10, 2020

airflow.contrib.operators.bigquery_check_operator.BigQueryValueCheckOperator is derived from airflow.operators.check_operator.ValueCheckOperator but needs to be derived from airflow.operators.sql.SQLValueCheckOperator instead.

Until this is done, airflow generates a lot of warnings from this line of code.

Fixes #10271

@boring-cyborg
Copy link

boring-cyborg bot commented Aug 10, 2020

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://apache-airflow-slack.herokuapp.com/

@mik-laj
Copy link
Member

mik-laj commented Aug 11, 2020

@dewaldabrie Can you look here? #10271

@dewaldabrie
Copy link
Author

@mik-laj Thanks, I replied there. Not sure why the checks in the CI is failing since it seems related to things I didn't touch like Add license for all SQL files.

@potiuk
Copy link
Member

potiuk commented Aug 12, 2020

We have a bug in the CI cache specification. I am going to fix it shortly

@potiuk
Copy link
Member

potiuk commented Aug 12, 2020

SHould be fixed now by #10299. I also cherry-picked it to 1-10-stable and 1-10-test. Can you please rebase again on top of the latest v1-10-stable and it should be fixed permanently now.

@potiuk
Copy link
Member

potiuk commented Aug 13, 2020

Hey @dewaldabrie - if you want this one to be part of 1.10.12 (willl be released very shortly) you should rebase this one

@potiuk potiuk added this to the Airflow 1.10.12 milestone Aug 13, 2020
@kaxil kaxil changed the base branch from v1-10-stable to v1-10-test August 14, 2020 19:04
@kaxil kaxil force-pushed the update_bigquery_check_operator_base_classes branch from e262e0e to 73e1934 Compare August 14, 2020 19:05
@kaxil kaxil merged commit 5f4aed9 into apache:v1-10-test Aug 14, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 14, 2020

Awesome work, congrats on your first merged pull request!

kaxil pushed a commit that referenced this pull request Aug 15, 2020
kaxil pushed a commit that referenced this pull request Aug 15, 2020
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants