Add ClusterPolicyViolation support to airflow local settings #10282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…airflow-aas into develop
|
@jaketf Can you add some docs? |
mik-laj
reviewed
Aug 10, 2020
mik-laj
reviewed
Aug 10, 2020
mik-laj
reviewed
Aug 10, 2020
mik-laj
reviewed
Aug 10, 2020
|
I don't think we need a separate option in airflow_local_settings. I think we can use the cluster policy. The example configuration file, you can find in |
mik-laj
reviewed
Aug 10, 2020
mik-laj
reviewed
Aug 10, 2020
mik-laj
reviewed
Aug 10, 2020
mik-laj
reviewed
Aug 10, 2020
mik-laj
reviewed
Aug 11, 2020
kaxil
reviewed
Aug 11, 2020
kaxil
reviewed
Aug 11, 2020
kaxil
reviewed
Aug 11, 2020
mik-laj
reviewed
Aug 11, 2020
kaxil
reviewed
Aug 11, 2020
mik-laj
reviewed
Aug 11, 2020
|
@kaxil Thanks for the review. I was just about to ask you for this as I am the author of some of the code for this change and an independent review would be helpful. |
kaxil
reviewed
Aug 11, 2020
kaxil
reviewed
Aug 11, 2020
kaxil
reviewed
Aug 11, 2020
kaxil
reviewed
Aug 11, 2020
kaxil
reviewed
Aug 11, 2020
Co-authored-by: Kaxil Naik <[email protected]>
Co-authored-by: Kaxil Naik <[email protected]>
Co-authored-by: Kaxil Naik <[email protected]>
Co-authored-by: Kaxil Naik <[email protected]>
mik-laj
approved these changes
Aug 12, 2020
kaxil
approved these changes
Aug 12, 2020
|
👏 Nice work @jaketf |
|
Indeed :). |
kaxil
pushed a commit
that referenced
this pull request
Aug 14, 2020
This change will allow users to throw other exceptions (namely `AirflowClusterPolicyViolation`) than `DagCycleException` as part of Cluster Policies. This can be helpful for running checks on tasks / DAGs (e.g. asserting task has a non-airflow owner) and failing to run tasks aren't compliant with these checks. This is meant as a tool for airflow admins to prevent user mistakes (especially in shared Airflow infrastructure with newbies) than as a strong technical control for security/compliance posture. (cherry picked from commit 7f76b8b)
kaxil
pushed a commit
that referenced
this pull request
Aug 15, 2020
This change will allow users to throw other exceptions (namely `AirflowClusterPolicyViolation`) than `DagCycleException` as part of Cluster Policies. This can be helpful for running checks on tasks / DAGs (e.g. asserting task has a non-airflow owner) and failing to run tasks aren't compliant with these checks. This is meant as a tool for airflow admins to prevent user mistakes (especially in shared Airflow infrastructure with newbies) than as a strong technical control for security/compliance posture. (cherry picked from commit 7f76b8b)
kaxil
pushed a commit
that referenced
this pull request
Aug 15, 2020
This change will allow users to throw other exceptions (namely `AirflowClusterPolicyViolation`) than `DagCycleException` as part of Cluster Policies. This can be helpful for running checks on tasks / DAGs (e.g. asserting task has a non-airflow owner) and failing to run tasks aren't compliant with these checks. This is meant as a tool for airflow admins to prevent user mistakes (especially in shared Airflow infrastructure with newbies) than as a strong technical control for security/compliance posture. (cherry picked from commit 7f76b8b)
potiuk
pushed a commit
to PolideaInternal/airflow
that referenced
this pull request
Oct 9, 2020
The custom ClusterPolicyViolation has been added in apache#10282 This one adds more comprehensive test to it.
potiuk
added a commit
that referenced
this pull request
Oct 9, 2020
The custom ClusterPolicyViolation has been added in #10282 This one adds more comprehensive test to it. Co-authored-by: Jacob Ferriero <[email protected]>
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
…10282) This change will allow users to throw other exceptions (namely `AirflowClusterPolicyViolation`) than `DagCycleException` as part of Cluster Policies. This can be helpful for running checks on tasks / DAGs (e.g. asserting task has a non-airflow owner) and failing to run tasks aren't compliant with these checks. This is meant as a tool for airflow admins to prevent user mistakes (especially in shared Airflow infrastructure with newbies) than as a strong technical control for security/compliance posture. (cherry picked from commit 7f76b8b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will allow users to throw other exceptions (namely
AirflowClusterPolicyViolation) thanDagCycleExceptionas part of Cluster Policies.This can be helpful for running checks on tasks / DAGs (e.g. asserting task has a non-airflow owner) and failing to run tasks aren't compliant with these checks.
This is meant as a tool for airflow admins to prevent user mistakes (especially in shared airlfow infrastructure with newbies) than as a strong technical control for security / compliance posture.
CC: @potiuk @mik-laj who are familiar with this change.