Fix issue with mounting volumes from secrets #10366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were using the "name" variable to merge or extend items, however this was problematic in volumes generated by secrets as the generated names would not collide leading to duplicate values (cherry picked from commit 635b04e9331f46cfb8b1810485681e8dc4581f38)
dimberman
force-pushed
the
k8s-regression-rc1
branch
from
ca6d0e5
to
dc657e5
Compare
kaxil
added
provider:cncf-kubernetes
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
* Fix issue with mounting volumes from secrets Previously, we were using the "name" variable to merge or extend items, however this was problematic in volumes generated by secrets as the generated names would not collide leading to duplicate values (cherry picked from commit 635b04e9331f46cfb8b1810485681e8dc4581f38) * fix tests * Simplified workflow. Secrets will no longer be converted to secret objects Co-authored-by: Daniel Imberman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10362
Previously, we were using the "name" variable to merge or extend
items, however this was problematic in volumes generated by secrets
as the generated names would not collide leading to duplicate values
(cherry picked from commit 635b04e9331f46cfb8b1810485681e8dc4581f38)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.