-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make models/taskinstance.py pylint compatible #10499
Merged
potiuk
merged 1 commit into
apache:master
from
PolideaInternal:make-models-taskinstance-pylint-compatible
Aug 24, 2020
Merged
Make models/taskinstance.py pylint compatible #10499
potiuk
merged 1 commit into
apache:master
from
PolideaInternal:make-models-taskinstance-pylint-compatible
Aug 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbaszek
reviewed
Aug 23, 2020
potiuk
force-pushed
the
make-models-taskinstance-pylint-compatible
branch
from
August 23, 2020 18:13
c66a582
to
0a523d1
Compare
Is this another attempt to fix cyclic imports? #9674 |
turbaszek
reviewed
Aug 24, 2020
turbaszek
reviewed
Aug 24, 2020
This one is still draft. Turned out that there is another cyclic dependency hidden in this one :). |
potiuk
changed the title
Make models/taskinstance.py pylint compatible
[WIP] Make models/taskinstance.py pylint compatible
Aug 24, 2020
potiuk
changed the title
[WIP] Make models/taskinstance.py pylint compatible
Make models/taskinstance.py pylint compatible
Aug 24, 2020
potiuk
force-pushed
the
make-models-taskinstance-pylint-compatible
branch
from
August 24, 2020 19:54
0a523d1
to
139e020
Compare
potiuk
commented
Aug 24, 2020
turbaszek
reviewed
Aug 24, 2020
turbaszek
reviewed
Aug 24, 2020
turbaszek
approved these changes
Aug 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This rocks 🎸
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.