Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make models/taskinstance.py pylint compatible #10499

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Aug 23, 2020


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@potiuk potiuk force-pushed the make-models-taskinstance-pylint-compatible branch from c66a582 to 0a523d1 Compare August 23, 2020 18:13
@turbaszek
Copy link
Member

Is this another attempt to fix cyclic imports? #9674

@potiuk
Copy link
Member Author

potiuk commented Aug 24, 2020

This one is still draft. Turned out that there is another cyclic dependency hidden in this one :).

@potiuk potiuk changed the title Make models/taskinstance.py pylint compatible [WIP] Make models/taskinstance.py pylint compatible Aug 24, 2020
@turbaszek turbaszek marked this pull request as draft August 24, 2020 09:37
@potiuk potiuk changed the title [WIP] Make models/taskinstance.py pylint compatible Make models/taskinstance.py pylint compatible Aug 24, 2020
@potiuk potiuk force-pushed the make-models-taskinstance-pylint-compatible branch from 0a523d1 to 139e020 Compare August 24, 2020 19:54
@potiuk potiuk marked this pull request as ready for review August 24, 2020 21:08
Copy link
Member

@turbaszek turbaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rocks 🎸

@potiuk potiuk merged commit 4f6d53e into apache:master Aug 24, 2020
@potiuk potiuk deleted the make-models-taskinstance-pylint-compatible branch August 24, 2020 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants