Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The entrypoints in Docker Image should be owned by Airflow #10853

Merged

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Sep 10, 2020

Since we are running the airflow image as airflow user, the
entrypoint and clear-logs scripts should also be set as airflow.

This had no impact if you actually run this as root user or
when your group was root (which was recommended).


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

Since we are running the airflow image as airflow user, the
entrypoint and clear-logs scripts should also be set as airflow.

This had no impact if you actually run this as root user or
when your group was root (which was recommended).
@potiuk potiuk merged commit d9920fa into apache:master Sep 12, 2020
@potiuk potiuk deleted the fix-user-when-copying-entrypoint branch September 12, 2020 08:54
potiuk added a commit to potiuk/airflow that referenced this pull request Sep 14, 2020
)

Since we are running the airflow image as airflow user, the
entrypoint and clear-logs scripts should also be set as airflow.

This had no impact if you actually run this as root user or
when your group was root (which was recommended).

(cherry picked from commit d9920fa)
potiuk added a commit that referenced this pull request Sep 15, 2020
Since we are running the airflow image as airflow user, the
entrypoint and clear-logs scripts should also be set as airflow.

This had no impact if you actually run this as root user or
when your group was root (which was recommended).

(cherry picked from commit d9920fa)
RaviTezu pushed a commit to RaviTezu/airflow that referenced this pull request Oct 25, 2020
)

Since we are running the airflow image as airflow user, the
entrypoint and clear-logs scripts should also be set as airflow.

This had no impact if you actually run this as root user or
when your group was root (which was recommended).

(cherry picked from commit d9920fa)
kaxil pushed a commit that referenced this pull request Nov 12, 2020
Since we are running the airflow image as airflow user, the
entrypoint and clear-logs scripts should also be set as airflow.

This had no impact if you actually run this as root user or
when your group was root (which was recommended).

(cherry picked from commit d9920fa)
@potiuk potiuk added this to the Airflow 1.10.13 milestone Nov 14, 2020
@potiuk potiuk added the type:improvement Changelog: Improvements label Nov 14, 2020
potiuk added a commit that referenced this pull request Nov 16, 2020
Since we are running the airflow image as airflow user, the
entrypoint and clear-logs scripts should also be set as airflow.

This had no impact if you actually run this as root user or
when your group was root (which was recommended).

(cherry picked from commit d9920fa)
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
)

Since we are running the airflow image as airflow user, the
entrypoint and clear-logs scripts should also be set as airflow.

This had no impact if you actually run this as root user or
when your group was root (which was recommended).

(cherry picked from commit d9920fa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants