-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Secrets backend for Microsoft Azure Key Vault #10898
Conversation
k8s failures are unrelated |
Need rebase - that was one of the previous master merges (fixed afterwards) I had the same problem with two other prs and it was fixed after rebase |
Co-authored-by: Elwin Arens <[email protected]>
6b06535
to
e8d7226
Compare
rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! one more secret backend!
I think we have a failing pylint in master now because of this one :( |
@kaxil ^^ |
Checking |
No, I think the test was cancelled because another PR was merged, I can't see any error |
In another PR |
I am running my PR rebased on master now https://github.com/apache/airflow/pull/10912/checks?check_run_id=1108699419 |
Hmm. It works. It was an interesting race condition that I must have to take a closer look at :) |
Allright I know @kaxil . It was manifestation of the #10471 Currenlty the image is built using the original commit, but the build itself is run using sources after the PR is automatically merged with master. So in the image there was no "azure-identity" and the other package added, but the sources used for pylint check already contained it (because we run static checks using the local sources). That makes me think that I might want to try to solve it eventually. |
(cherry picked from commit f77a11d)
(cherry picked from commit f77a11d)
(cherry picked from commit f77a11d)
(cherry picked from commit f77a11d)
Thanks for the effort of picking up where i left, everyone! |
(cherry picked from commit f77a11d)
(cherry picked from commit f77a11d)
(cherry picked from commit f77a11d)
(cherry picked from commit f77a11d)
Co-authored-by: Elwin Arens [email protected]
closes: #8258
This PR adds secrets backend for Microsoft azure key vault
This work was started at #9639
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.