Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Secrets backend for Microsoft Azure Key Vault #10898

Merged
merged 2 commits into from
Sep 13, 2020

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Sep 12, 2020

Co-authored-by: Elwin Arens [email protected]

closes: #8258

This PR adds secrets backend for Microsoft azure key vault

This work was started at #9639


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@kaxil
Copy link
Member Author

kaxil commented Sep 12, 2020

k8s failures are unrelated

@potiuk
Copy link
Member

potiuk commented Sep 12, 2020

k8s failures are unrelated

Need rebase - that was one of the previous master merges (fixed afterwards) I had the same problem with two other prs and it was fixed after rebase

@kaxil
Copy link
Member Author

kaxil commented Sep 12, 2020

k8s failures are unrelated

Need rebase - that was one of the previous master merges (fixed afterwards) I had the same problem with two other prs and it was fixed after rebase

rebased

@kaxil kaxil requested a review from feluelle September 13, 2020 12:12
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! one more secret backend!

@potiuk potiuk merged commit f77a11d into apache:master Sep 13, 2020
@kaxil kaxil deleted the azure-serets-manager branch September 13, 2020 14:51
@potiuk
Copy link
Member

potiuk commented Sep 13, 2020

I think we have a failing pylint in master now because of this one :(

@potiuk
Copy link
Member

potiuk commented Sep 13, 2020

@kaxil ^^

@kaxil
Copy link
Member Author

kaxil commented Sep 13, 2020

Checking

@kaxil
Copy link
Member Author

kaxil commented Sep 13, 2020

No, I think the test was cancelled because another PR was merged, I can't see any error

@potiuk
Copy link
Member

potiuk commented Sep 13, 2020

@potiuk
Copy link
Member

potiuk commented Sep 13, 2020

In another PR

@potiuk
Copy link
Member

potiuk commented Sep 13, 2020

I am running my PR rebased on master now https://github.com/apache/airflow/pull/10912/checks?check_run_id=1108699419

@potiuk
Copy link
Member

potiuk commented Sep 13, 2020

Hmm. It works. It was an interesting race condition that I must have to take a closer look at :)

@potiuk
Copy link
Member

potiuk commented Sep 13, 2020

Allright I know @kaxil . It was manifestation of the #10471

Currenlty the image is built using the original commit, but the build itself is run using sources after the PR is automatically merged with master. So in the image there was no "azure-identity" and the other package added, but the sources used for pylint check already contained it (because we run static checks using the local sources).

That makes me think that I might want to try to solve it eventually.

kaxil added a commit that referenced this pull request Sep 18, 2020
potiuk pushed a commit that referenced this pull request Sep 18, 2020
kaxil added a commit to astronomer/airflow that referenced this pull request Sep 18, 2020
@elwinarens
Copy link

Thanks for the effort of picking up where i left, everyone!

RaviTezu pushed a commit to RaviTezu/airflow that referenced this pull request Oct 25, 2020
kaxil added a commit that referenced this pull request Nov 12, 2020
@potiuk potiuk added the type:improvement Changelog: Improvements label Nov 14, 2020
@potiuk potiuk added this to the Airflow 1.10.13 milestone Nov 14, 2020
potiuk pushed a commit that referenced this pull request Nov 16, 2020
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:secrets provider:microsoft-azure Azure-related issues type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Azure key vault secrets backend
3 participants