Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace logo with SVG that includes name in proper typography #11018

Merged
merged 1 commit into from
Sep 18, 2020

Conversation

ryanahamilton
Copy link
Contributor

@ryanahamilton ryanahamilton commented Sep 18, 2020

related: #10953

Replaces the PNG + HTML text version of the Airflow logo with an SVG that yields both the pinwheel and "Airflow" text. The prior implementation simply used the default font-family (Helvetica Neue) for the brand name, where this implementation uses the brand font-family (Rubik). This ensures that brand font is always locked up with the logo in cases where an end-user may apply a custom theme (e.g. different default font-family).

I left the old static asset (pin_100.png) in the file system as it appears to still be in use by a Slack Operator.

If you stare long enough, you'll see the typography differences 😃

Before After
image image

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Sep 18, 2020
Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see where the font is used?

How big is the SVG? Is it worth making it an external resource so it's cached/only requested once?

@ryanahamilton
Copy link
Contributor Author

@ashb "I don't see where the don't is used?" typo?

For smaller icon/logo SVGs, I typically opt for inline rendering and forgo the extra request.

@ashb ashb merged commit f16f474 into apache:master Sep 18, 2020
@ryanahamilton ryanahamilton deleted the navbar_brand_logo branch September 18, 2020 19:58
@ryanahamilton ryanahamilton added the area:UI Related to UI/UX. For Frontend Developers. label Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants