Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Helm Chart linting #11108

Merged

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Sep 23, 2020


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@potiuk
Copy link
Member Author

potiuk commented Sep 23, 2020

cc: @jaketf @mik-laj

@potiuk potiuk requested a review from mik-laj September 23, 2020 17:57
@kaxil
Copy link
Member

kaxil commented Sep 23, 2020

hmm the CI is stuck

@potiuk
Copy link
Member Author

potiuk commented Sep 23, 2020

Seems like we do experience some smaller job queue or smth like that. I might have to speed up my "selective tests work".

@potiuk
Copy link
Member Author

potiuk commented Sep 23, 2020

Looks awfully like some of the Travis problems we had.

@kaxil
Copy link
Member

kaxil commented Sep 23, 2020

Looks awfully like some of the Travis problems we had.

:( yeah

@turbaszek
Copy link
Member

This looks like a flaky / side effect?

______________________ TestConf.test_conf_as_dict_source _______________________
1164

1165
self = <tests.test_configuration.TestConf testMethod=test_conf_as_dict_source>
1166

1167
    def test_conf_as_dict_source(self):
1168
        # test display_source
1169
        cfg_dict = conf.as_dict(display_source=True)
1170
>       self.assertEqual(
1171
            cfg_dict['core']['load_examples'][1], 'airflow.cfg')
1172
E       AssertionError: 'env var' != 'airflow.cfg'
1173
E       - env var
1174
E       + airflow.cfg

@kaxil
Copy link
Member

kaxil commented Sep 24, 2020

This looks like a flaky / side effect?

______________________ TestConf.test_conf_as_dict_source _______________________
1164

1165
self = <tests.test_configuration.TestConf testMethod=test_conf_as_dict_source>
1166

1167
    def test_conf_as_dict_source(self):
1168
        # test display_source
1169
        cfg_dict = conf.as_dict(display_source=True)
1170
>       self.assertEqual(
1171
            cfg_dict['core']['load_examples'][1], 'airflow.cfg')
1172
E       AssertionError: 'env var' != 'airflow.cfg'
1173
E       - env var
1174
E       + airflow.cfg

This is fixed in master

@potiuk potiuk merged commit 620b098 into apache:master Sep 24, 2020
@potiuk potiuk deleted the add-helm-linting-for-helm-chart branch September 24, 2020 11:02
@potiuk potiuk added this to the Airflow 1.10.13 milestone Sep 25, 2020
potiuk added a commit that referenced this pull request Sep 25, 2020
(cherry picked from commit 620b098)
RaviTezu pushed a commit to RaviTezu/airflow that referenced this pull request Oct 25, 2020
kaxil pushed a commit that referenced this pull request Nov 12, 2020
(cherry picked from commit 620b098)
@potiuk potiuk added the type:misc/internal Changelog: Misc changes that should appear in change log label Nov 14, 2020
potiuk added a commit that referenced this pull request Nov 16, 2020
(cherry picked from commit 620b098)
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
(cherry picked from commit 620b098)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants