Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breeze: Fix issue with pulling an image via ID #11255

Merged
merged 1 commit into from
Oct 3, 2020

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Oct 3, 2020

Error:

❯ ./breeze --github-image-id 285629517

GitHub image id: 285629517

Force pulling the image, using github registry and skip mounting local sources.
This is in order to get the exact same version as used in CI environment for SHA/RUN_ID!.

Must provide --username with --password-stdin

After the fix from the PR it works fine.

❯ ./breeze --github-image-id 285629517

GitHub image id: 285629517

Force pulling the image, using github registry and skip mounting local sources.
This is in order to get the exact same version as used in CI environment for SHA/RUN_ID!.

Login Succeeded

Force pull base image python:3.6-slim-buster

Pulling the image docker.pkg.github.com/apache/airflow/python:3.6-slim-buster-285629517


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

Error:

```
❯ ./breeze --github-image-id 285629517

GitHub image id: 285629517

Force pulling the image, using github registry and skip mounting local sources.
This is in order to get the exact same version as used in CI environment for SHA/RUN_ID!.

Must provide --username with --password-stdin
```

After the fix from the PR it works fine.

```
❯ ./breeze --github-image-id 285629517

GitHub image id: 285629517

Force pulling the image, using github registry and skip mounting local sources.
This is in order to get the exact same version as used in CI environment for SHA/RUN_ID!.

Login Succeeded

Force pull base image python:3.6-slim-buster

Pulling the image docker.pkg.github.com/apache/airflow/python:3.6-slim-buster-285629517

```
@kaxil kaxil merged commit 3db2e7c into apache:master Oct 3, 2020
@kaxil kaxil deleted the fix-github-image-issue branch October 3, 2020 11:56
@potiuk
Copy link
Member

potiuk commented Oct 3, 2020

Ah yrah. The root cause was that you had GITHUB_TOKEN variable defined :).

I've seen it recently and had no time to fix it. Thanks for fixing it @kaxil :).

potiuk pushed a commit that referenced this pull request Oct 3, 2020
@potiuk potiuk added this to the Airflow 1.10.13 milestone Oct 3, 2020
RaviTezu pushed a commit to RaviTezu/airflow that referenced this pull request Oct 25, 2020
kaxil added a commit that referenced this pull request Nov 12, 2020
@potiuk potiuk added the type:misc/internal Changelog: Misc changes that should appear in change log label Nov 14, 2020
potiuk pushed a commit that referenced this pull request Nov 16, 2020
kaxil added a commit that referenced this pull request Nov 18, 2020
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants