Use rst lexer to format airflow upgrade check output #11259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbaszek
added
the
area:upgrade
|
What do you think to use rich? It looks a little more user-friendly. |
|
Rich is Py 3.6 only though |
I think the rich is something that we should consider in future (for multiple commands). For now, I would prefer to stick to what we have and keep it simple. |
kaxil
approved these changes
Oct 3, 2020
mik-laj
approved these changes
Oct 3, 2020
potiuk
force-pushed
the
v1-10-test
branch
2 times, most recently
from
bd4214b
to
195f00d
Compare
turbaszek
force-pushed
the
improve-ux-airflow-upgrade-check
branch
from
4a46aa6
to
19621e6
Compare
Instead of displaying plain text we can use pygments formatter and lexer to improve readability and UX of airflow upgrade_check command.
turbaszek
force-pushed
the
improve-ux-airflow-upgrade-check
branch
from
19621e6
to
9a70012
Compare
turbaszek
added a commit
to PolideaInternal/airflow
that referenced
this pull request
Oct 21, 2020
Instead of displaying plain text we can use pygments formatter and lexer to improve readability and UX of airflow upgrade_check command.
turbaszek
added a commit
to PolideaInternal/airflow
that referenced
this pull request
Oct 23, 2020
Instead of displaying plain text we can use pygments formatter and lexer to improve readability and UX of airflow upgrade_check command. (cherry picked from commit 7d83661)
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
Instead of displaying plain text we can use pygments formatter and lexer to improve readability and UX of airflow upgrade_check command. (cherry picked from commit 7d83661)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of displaying plain text we can use pygments formatter and lexer
to improve readability and UX of airflow upgrade_check command.
Before
After
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.