Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically upgrade old default navbar color #11322

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

ashb
Copy link
Member

@ashb ashb commented Oct 7, 2020

As part of #11195 we re-styled the UI, changing a lot of the default
colours to make them look more modern. However for anyone upgrading and
keeping their airflow.cfg from 1.10 to 2.0 they would end up with things
looking a bit ugly, as the old navbar color would be kept.

This uses the existing config value upgrade feature to automatically
change the old default colour in to the new default colour.

This is what it looks like without this change

image


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

As part of apache#11195 we re-styled the UI, changing a lot of the default
colours to make them look more modern. However for anyone upgrading and
keeping their airflow.cfg from 1.10 to 2.0 they would end up with things
looking a bit ugly, as the old navbar color would be kept.

This uses the existing config value upgrade feature to automatically
change the old default colour in to the new default colour.
@ashb ashb requested a review from kaxil October 7, 2020 08:17
@ashb ashb merged commit d86cf37 into apache:master Oct 7, 2020
@ashb ashb deleted the ignore-old-default-navbar-colour branch October 7, 2020 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants