Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass SQLAlchemy engine options to FAB based UI #11395

Merged
merged 6 commits into from
Oct 16, 2020

Conversation

michalmisiewicz
Copy link
Contributor

This PR fixes #11394

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Oct 10, 2020
@michalmisiewicz
Copy link
Contributor Author

@kaxil @turbaszek @mik-laj

airflow/settings.py Outdated Show resolved Hide resolved
Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, needs atleast a test to check when config is set, if is reflected in flask_app.config

@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

@michalmisiewicz
Copy link
Contributor Author

@kaxil Test added

@michalmisiewicz
Copy link
Contributor Author

@kaxil @turbaszek Are we ready for merge ?

@turbaszek turbaszek merged commit 91484b9 into apache:master Oct 16, 2020
Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

@ashb ashb added this to the Airflow 1.10.13 milestone Nov 19, 2020
kaxil pushed a commit that referenced this pull request Nov 19, 2020
Co-authored-by: Tomek Urbaszek <[email protected]>
(cherry picked from commit 91484b9)
kaxil pushed a commit that referenced this pull request Nov 19, 2020
Co-authored-by: Tomek Urbaszek <[email protected]>
(cherry picked from commit 91484b9)
kaxil pushed a commit that referenced this pull request Nov 20, 2020
Co-authored-by: Tomek Urbaszek <[email protected]>
(cherry picked from commit 91484b9)
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
Co-authored-by: Tomek Urbaszek <[email protected]>
(cherry picked from commit 91484b9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQLAlchemy engine configuration is not passed to FAB based UI
4 participants