Add Markdown linting to pre-commit #11465
Conversation
|
@jbampton can you please check if it would be possible to add this tool to pre-commit config? In this way, files will be linted before commit and this speeds up the feedback loop. |
|
Seems that this is even added in the original markdown lint repo - so should be super easy to add ot our .pre-commit-config.yml https://github.com/markdownlint/markdownlint/blob/master/.pre-commit-hooks.yaml |
ashb
added
area:CI
|
Any news about pre-commit version of the markdown lint @jbampton ? |
|
@jbampton do you need any help? |
jbampton
force-pushed
the
markdownlint
branch
from
2340355
to
29c26f2
Compare
jbampton
changed the title
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*. |
jbampton
force-pushed
the
markdownlint
branch
2 times, most recently
from
671531b
to
f8e3461
Compare
jbampton
force-pushed
the
markdownlint
branch
from
f8e3461
to
ed458c4
Compare
- Add a basic config file - Lint Markdown https://www.npmjs.com/package/markdownlint-cli
jbampton
force-pushed
the
markdownlint
branch
from
ed458c4
to
1049b32
Compare
|
Hey @turbaszek @potiuk @mik-laj this PR is ready for review 👍 |
|
Awesome! Can you create an issue about the remaining rules (similar to #10742) ? |
(cherry picked from commit 7463b6b)
potiuk
added
the
type:misc/internal
(cherry picked from commit 7463b6b)
(cherry picked from commit 7463b6b)
https://www.npmjs.com/package/markdownlint-cli
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.