fix pod launcher rolebinding in helm chart #11675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Followup to apache#11034 * Was not referencing the correct kind of resources if multiNamespaceMode = False
|
Also, there is an issue in the
|
dimberman
approved these changes
Oct 20, 2020
|
Awesome work, congrats on your first merged pull request! |
|
Thanks @dimberman . |
michalmisiewicz
pushed a commit
to michalmisiewicz/airflow
that referenced
this pull request
Oct 30, 2020
* Followup to apache#11034 * Was not referencing the correct kind of resources if multiNamespaceMode = False
potiuk
pushed a commit
that referenced
this pull request
Nov 15, 2020
potiuk
pushed a commit
that referenced
this pull request
Nov 16, 2020
potiuk
pushed a commit
that referenced
this pull request
Nov 16, 2020
kaxil
pushed a commit
that referenced
this pull request
Nov 18, 2020
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
* Followup to apache#11034 * Was not referencing the correct kind of resources if multiNamespaceMode = False (cherry picked from commit 3391c90)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR is a tiny followup to #11034: if
multiNamespaceMode = Falsethen we should reference aRoleand not aClusterRolein the roleRef ofpod-launcher-rolebinding.yaml.Also,
with #11034 & this PR, we should be able to close #10190.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.