Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign release files with an apache.org key by default #12241

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

ashb
Copy link
Member

@ashb ashb commented Nov 10, 2020

If you have more than a single private key in your GPG trust store, gpg
will use the first one, which for me is not right.

This changes the script to by default use any key with apache.org in
the name. This is a patch I've been carrying locally for about 8
releases now :D


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

If you have more than a single private key in your GPG trust store, gpg
will use the first one, which for me is not right.

This changes the script to by default use any key with `apache.org` in
the name. This is a patch I've been carrying locally for about 8
releases now :D
@ashb ashb added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Nov 10, 2020
@ashb ashb requested review from kaxil and potiuk November 10, 2020 11:00
@ashb
Copy link
Member Author

ashb commented Nov 10, 2020

Tagging Jarek and Kaxil as you're the only ones to have done releases any time recently.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Nov 10, 2020
@github-actions
Copy link

The PR is ready to be merged. No tests are needed!

@kaxil kaxil merged commit 3ab5828 into apache:master Nov 10, 2020
@kaxil kaxil deleted the sign-configurable-key branch November 10, 2020 11:26
kaxil pushed a commit that referenced this pull request Mar 10, 2021
If you have more than a single private key in your GPG trust store, gpg
will use the first one, which for me is not right.

This changes the script to by default use any key with `apache.org` in
the name. This is a patch I've been carrying locally for about 8
releases now :D

(cherry picked from commit 3ab5828)
kaxil pushed a commit that referenced this pull request Mar 10, 2021
If you have more than a single private key in your GPG trust store, gpg
will use the first one, which for me is not right.

This changes the script to by default use any key with `apache.org` in
the name. This is a patch I've been carrying locally for about 8
releases now :D

(cherry picked from commit 3ab5828)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants