-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove providers imports from core examples #12252
Remove providers imports from core examples #12252
Conversation
entry: ./scripts/ci/pre_commit/pre_commit_check_pre_commits.sh | ||
language: system | ||
files: ^.pre-commit-config.yaml$|^STATIC_CODE_CHECKS.rst|^breeze-complete$ | ||
require_serial: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this as it was duplicated:
airflow/.pre-commit-config.yaml
Lines 397 to 402 in 3ddf4d0
- id: pre-commit-descriptions | |
name: Check if pre-commits are described | |
entry: ./scripts/ci/pre_commit/pre_commit_check_pre_commits.sh | |
language: system | |
files: ^.pre-commit-config.yaml$|^STATIC_CODE_CHECKS.rst|^breeze-complete$ | |
require_serial: true |
airflow/.pre-commit-config.yaml
Lines 459 to 464 in 3ddf4d0
- id: pre-commit-descriptions | |
name: Check if pre-commits are described | |
entry: ./scripts/ci/pre_commit/pre_commit_check_pre_commits.sh | |
language: system | |
files: ^.pre-commit-config.yaml$|^STATIC_CODE_CHECKS.rst|^breeze-complete$ | |
require_serial: true |
6153fa9
to
342c905
Compare
@@ -145,6 +146,8 @@ class _PythonDecoratedOperator(BaseOperator): | |||
""" | |||
|
|||
template_fields = ('op_args', 'op_kwargs') | |||
template_fields_renderers = {"op_args": "py", "op_kwargs": "py"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@turbaszek There is no reason. I've tried to move providers as many as possible, but we can move it back to the core. |
The PR needs to run all tests because it modifies core of Airflow! Please rebase it to latest master or ask committer to re-run it! |
Core example DAGs should not depend on any non-core dependency like providers packages. closes: apache#12247
342c905
to
264e1bb
Compare
Co-authored-by: Xiaodong DENG <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one @turbaszek ✅
Core example DAGs should not depend on any non-core dependency
like providers packages.
I also added a pre-commit check to avoid regression:
closes: #12247
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.