Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Get all "tags" parameters not just one for status filters #12324

Merged

Conversation

ryanahamilton
Copy link
Contributor

Resolves #12313

Given the following multi "tags" parameters in the URLs, the request.args.get was only getting a single parameter instead of all of them.

/home?tags=example&tags=example2&tags=example3

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Nov 12, 2020
@ryanahamilton ryanahamilton added this to the Airflow 2.0.0-beta3 milestone Nov 12, 2020
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Nov 12, 2020
@github-actions
Copy link

The PR should be OK to be merged with just subset of tests as it does not modify Core of Airflow. The committers might merge it or can add a label 'full tests needed' and re-run it to run all tests if they see it is needed!

@ryanahamilton ryanahamilton merged commit 7f828b0 into apache:master Nov 12, 2020
@ryanahamilton ryanahamilton deleted the fix/persist_tags_with_status branch November 12, 2020 21:45
vlive1111 pushed a commit to vlive1111/airflow that referenced this pull request Nov 13, 2020
@ryanahamilton ryanahamilton added the area:UI Related to UI/UX. For Frontend Developers. label Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The "Filter tags" multi-select container can't hold the selected tags while switching between views
4 participants