Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve presentation of DAG Docs #12330

Merged
merged 2 commits into from
Nov 13, 2020
Merged

Conversation

ryanahamilton
Copy link
Contributor

Noticed that the DAG docs/comments weren't looking so sharp… Refactored their markup/presentation a bit to now be contained within an accordion. It is still only conditionally displayed on the Tree and Graph views.

Before:
image

After:
Screen Recording 2020-11-12 at 07 20 53 PM

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Nov 13, 2020
@github-actions
Copy link

The PR should be OK to be merged with just subset of tests as it does not modify Core of Airflow. The committers might merge it or can add a label 'full tests needed' and re-run it to run all tests if they see it is needed!

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Nov 13, 2020
Copy link
Member

@ryw ryw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@kaxil
Copy link
Member

kaxil commented Nov 13, 2020

tests are failing:

FAILED tests/www/test_views.py::TestAirflowBaseViews::test_code - jinja2.exce...
FAILED tests/www/test_views.py::TestAirflowBaseViews::test_code_from_db - jin...
FAILED tests/www/test_views.py::TestAirflowBaseViews::test_code_from_db_all_example_dags
FAILED tests/www/test_views.py::TestAirflowBaseViews::test_code_no_file - jin...
FAILED tests/www/test_views.py::TestAirflowBaseViews::test_dag_details - jinj...
FAILED tests/www/test_views.py::TestAirflowBaseViews::test_dag_details_subdag
FAILED tests/www/test_views.py::TestAirflowBaseViews::test_dag_details_trigger_origin_graph_view
FAILED tests/www/test_views.py::TestAirflowBaseViews::test_dag_details_trigger_origin_tree_view
FAILED tests/www/test_views.py::TestAirflowBaseViews::test_duration - jinja2....
FAILED tests/www/test_views.py::TestAirflowBaseViews::test_gantt - jinja2.exc...
FAILED tests/www/test_views.py::TestAirflowBaseViews::test_landing_times - ji...
FAILED tests/www/test_views.py::TestAirflowBaseViews::test_rendered_k8s - jin...
FAILED tests/www/test_views.py::TestAirflowBaseViews::test_rendered_template
FAILED tests/www/test_views.py::TestAirflowBaseViews::test_task - jinja2.exce...
FAILED tests/www/test_views.py::TestAirflowBaseViews::test_tries - jinja2.exc...
FAILED tests/www/test_views.py::TestAirflowBaseViews::test_view_uses_existing_dagbag_2_dag_details
FAILED tests/www/test_views.py::TestAirflowBaseViews::test_xcom - jinja2.exce...
FAILED tests/www/test_views.py::TestGanttView::test_dt_nr_dr_form_default_parameters
FAILED tests/www/test_views.py::TestGanttView::test_dt_nr_dr_form_with_base_date_and_num_runs_and_execution_date_outside
FAILED tests/www/test_views.py::TestGanttView::test_dt_nr_dr_form_with_base_date_and_num_runs_and_execution_date_within
FAILED tests/www/test_views.py::TestGanttView::test_dt_nr_dr_form_with_base_date_and_num_runs_parameters_only
FAILED tests/www/test_views.py::TestGanttView::test_dt_nr_dr_form_with_execution_date_parameter_only
FAILED tests/www/test_views.py::TestDagACLView::test_code_success - jinja2.ex...
FAILED tests/www/test_views.py::TestDagACLView::test_code_success_for_all_dag_user
FAILED tests/www/test_views.py::TestDagACLView::test_dag_details_success - ji...
FAILED tests/www/test_views.py::TestDagACLView::test_dag_details_success_for_all_dag_user
FAILED tests/www/test_views.py::TestDagACLView::test_duration_success - jinja...
FAILED tests/www/test_views.py::TestDagACLView::test_gantt_success - jinja2.e...
FAILED tests/www/test_views.py::TestDagACLView::test_landing_times_success - ...
FAILED tests/www/test_views.py::TestDagACLView::test_log_success - jinja2.exc...
FAILED tests/www/test_views.py::TestDagACLView::test_log_success_for_user - j...
FAILED tests/www/test_views.py::TestDagACLView::test_rendered_template_success
FAILED tests/www/test_views.py::TestDagACLView::test_rendered_template_success_for_all_dag_user
FAILED tests/www/test_views.py::TestDagACLView::test_task_success - jinja2.ex...
FAILED tests/www/test_views.py::TestDagACLView::test_task_success_for_all_dag_user
FAILED tests/www/test_views.py::TestDagACLView::test_tries_success - jinja2.e...
FAILED tests/www/test_views.py::TestDagACLView::test_xcom_success - jinja2.ex...
FAILED tests/www/test_views.py::TestDagACLView::test_xcom_success_for_all_dag_user
FAILED tests/www/test_views.py::TestRenderedView::test_rendered_template_view
FAILED tests/www/test_views.py::TestRenderedView::test_rendered_template_view_for_unexecuted_tis
FAILED tests/www/test_views.py::TestRenderedView::test_user_defined_filter_and_macros_raise_error
FAILED tests/www/test_views.py::TestExtraLinks::test_extra_link_in_gantt_view

@ryanahamilton ryanahamilton merged commit 450bd32 into apache:master Nov 13, 2020
@ryanahamilton ryanahamilton deleted the dag_docs branch November 13, 2020 17:35
@ryanahamilton ryanahamilton added the area:UI Related to UI/UX. For Frontend Developers. label Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants