Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper exit status for failed CLI requests #12375

Merged
merged 2 commits into from
Nov 15, 2020
Merged

Proper exit status for failed CLI requests #12375

merged 2 commits into from
Nov 15, 2020

Commits on Nov 15, 2020

  1. More proper exit status for failed CLI requests 

    Some CLI commands simply `print` messages when the requests fail.
The issue is the exit code for these commands are `0` while it should be non-zero.

More proper exist status ensures people can better make use of the CLI.
    @XD-DENG
    XD-DENG committed Nov 15, 2020
    Configuration menu
    Copy the full SHA
    9c68a15 View commit details
    Browse the repository at this point in the history

  2. Fix-up. Update tests.

    @XD-DENG
    XD-DENG committed Nov 15, 2020
    Configuration menu
    Copy the full SHA
    f5b1468 View commit details
    Browse the repository at this point in the history