Remove inapplicable configuration section [ldap] (since 2.0.0) #12386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ldap] section in airflow.cfg is not applicable anymore in 2.0 and master, because the LDAP authentication (for webserver and API) is handled by FAB, and the configuration for this is handled by webserver_config.py file.
|
Hi @ashb , please help decide if this should be in beta3 or beta4. For now I put beta4 first. |
ashb
approved these changes
Nov 16, 2020
github-actions
bot
added
the
full tests needed
|
The PR needs to run all tests because it modifies core of Airflow! Please rebase it to latest master or ask committer to re-run it! |
XD-DENG
removed
the
full tests needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12385
[ldap]section inairflow.cfgis not applicable anymore in 2.0 and master, because the LDAP authentication (for webserver and API) is handled by FAB, and the configuration for this is handled bywebserver_config.pyfile.In this PR, the
[ldap]section is removed fromairflow/config_templates/default_airflow.cfgandairflow/config_templates/config.yml(and some other applicable files).^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.