Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the default value for VaultBackend's config_path #12518

Merged
merged 1 commit into from
Nov 20, 2020

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Nov 20, 2020

It is config not configs


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@kaxil kaxil added this to the Airflow 1.10.13 milestone Nov 20, 2020
@kaxil kaxil requested a review from ashb November 20, 2020 20:50
@kaxil
Copy link
Member Author

kaxil commented Nov 20, 2020

I was bit by this when reproducing #11149

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Nov 20, 2020
@github-actions
Copy link

The PR should be OK to be merged with just subset of tests as it does not modify Core of Airflow. The committers might merge it or can add a label 'full tests needed' and re-run it to run all tests if they see it is needed!

@ashb
Copy link
Member

ashb commented Nov 20, 2020

Not quite sure why spell check build failed -- I can't find the error amongst all the spew about intersphinx

@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

kaxil added a commit that referenced this pull request Nov 20, 2020
@kaxil
Copy link
Member Author

kaxil commented Nov 20, 2020

Looks like it was a. transient failure, passed this time

@kaxil kaxil merged commit 36a9b0f into apache:master Nov 20, 2020
@kaxil kaxil deleted the fix-default branch November 20, 2020 21:52
kaxil added a commit that referenced this pull request Nov 21, 2020
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:secrets okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants