Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds possibility of forcing upgrade constraint by setting a label #12635

Merged

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Nov 25, 2020

You can now set a label on PR that will force upgrading to latest
dependencies in your PR. If committer sets an
"upgrade to latest dependencies" label, it will cause the PR
to upgrade all dependencies to latest versions of dependencies
matching setup.py + setup.cfg configuration.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

You can now set a label on PR that will force upgrading to latest
dependencies in your PR. If committer sets an
"upgrade to latest dependencies" label, it will cause the PR
to upgrade all dependencies to latest versions of dependencies
matching setup.py + setup.cfg configuration.
@potiuk
Copy link
Member Author

potiuk commented Nov 25, 2020

This change will be very helpful in case of trying to upgrade to latest constraints in new PRs. Something that we do now with @turbaszek with #12508 to complete #10854 -> clean up the dependencies and get rid of conflicts.

Once this PR gets merged, commiters will be able to add "upgrade to latest dependencies" label to a PR and the image for that PR will be automatically built with the latest constraints that match the setup.py (without looking at the constraints file). This will be super-helpful in case we have some new dependencies added that will cause conflicts (when we add pip-check any conflicts will be detected automatically).

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Nov 26, 2020
@github-actions
Copy link

The PR needs to run all tests because it modifies core of Airflow! Please rebase it to latest master or ask committer to re-run it!

@potiuk potiuk merged commit 8b9d52f into apache:master Nov 26, 2020
@potiuk potiuk deleted the manual-upgrade-to-latest-constraints branch November 26, 2020 10:02
potiuk added a commit that referenced this pull request Nov 29, 2020
…2635)

You can now set a label on PR that will force upgrading to latest
dependencies in your PR. If committer sets an
"upgrade to latest dependencies" label, it will cause the PR
to upgrade all dependencies to latest versions of dependencies
matching setup.py + setup.cfg configuration.

(cherry picked from commit 8b9d52f)
@potiuk potiuk added this to the Airflow 1.10.14 milestone Nov 30, 2020
@potiuk potiuk added the type:misc/internal Changelog: Misc changes that should appear in change log label Nov 30, 2020
kaxil pushed a commit that referenced this pull request Dec 3, 2020
…2635)

You can now set a label on PR that will force upgrading to latest
dependencies in your PR. If committer sets an
"upgrade to latest dependencies" label, it will cause the PR
to upgrade all dependencies to latest versions of dependencies
matching setup.py + setup.cfg configuration.

(cherry picked from commit 8b9d52f)
ashb pushed a commit that referenced this pull request Dec 3, 2020
…2635)

You can now set a label on PR that will force upgrading to latest
dependencies in your PR. If committer sets an
"upgrade to latest dependencies" label, it will cause the PR
to upgrade all dependencies to latest versions of dependencies
matching setup.py + setup.cfg configuration.

(cherry picked from commit 8b9d52f)
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
…ache#12635)

You can now set a label on PR that will force upgrading to latest
dependencies in your PR. If committer sets an
"upgrade to latest dependencies" label, it will cause the PR
to upgrade all dependencies to latest versions of dependencies
matching setup.py + setup.cfg configuration.

(cherry picked from commit 8b9d52f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools full tests needed We need to run full set of tests for this PR to merge type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants