Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup.cfg change triggers full build #12684

Merged

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Nov 28, 2020

Since we moved part of the setup.py specification to
setup.cfg, we should trigger full build when only that file
changes.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

Since we moved part of the setup.py specification to
setup.cfg, we should trigger full build when only that file
changes.
@potiuk
Copy link
Member Author

potiuk commented Nov 28, 2020

@ashb - after the dependencies were moved to setup.cfg the setup.cfg should be added to "important" files triggering whole build.

Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whops, thought I did this.

Clearly not

@github-actions
Copy link

The PR needs to run all tests because it modifies core of Airflow! Please rebase it to latest master or ask committer to re-run it!

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Nov 28, 2020
@potiuk
Copy link
Member Author

potiuk commented Nov 28, 2020

Whops, thought I did this.

Clearly not

Probably only in Breeze. This one is a selective check in CI - and those are different criteria. For Breeze change in the file triggers the need for image build. For selective checks, it triggers "all tests"

@potiuk potiuk merged commit e4ab453 into apache:master Nov 28, 2020
@potiuk potiuk deleted the add-setup-cfg-to-important-files branch November 28, 2020 11:39
potiuk added a commit that referenced this pull request Nov 29, 2020
Since we moved part of the setup.py specification to
setup.cfg, we should trigger full build when only that file
changes.

(cherry picked from commit e4ab453)
@potiuk potiuk added this to the Airflow 1.10.14 milestone Nov 30, 2020
@potiuk potiuk added the type:misc/internal Changelog: Misc changes that should appear in change log label Nov 30, 2020
kaxil pushed a commit that referenced this pull request Dec 3, 2020
Since we moved part of the setup.py specification to
setup.cfg, we should trigger full build when only that file
changes.

(cherry picked from commit e4ab453)
ashb pushed a commit that referenced this pull request Dec 3, 2020
Since we moved part of the setup.py specification to
setup.cfg, we should trigger full build when only that file
changes.

(cherry picked from commit e4ab453)
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
Since we moved part of the setup.py specification to
setup.cfg, we should trigger full build when only that file
changes.

(cherry picked from commit e4ab453)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools full tests needed We need to run full set of tests for this PR to merge type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants