Improve error handling in cli and introduce consistency #12764
Conversation
This PR is a followup after apache#12375 and apache#12704 it improves handling of some errors in cli commands to avoid show users to much traceback and uses SystemExit consitently.
boring-cyborg
bot
added
area:CLI
provider:cncf-kubernetes
| if uri_parts.scheme == '' or uri_parts.netloc == '': | ||
| return False | ||
| return True | ||
| return uri_parts.scheme != '' or uri_parts.netloc != '' |
There was a problem hiding this comment.
This should be changed into uri_parts.scheme != '' and uri_parts.netloc != '', instinct from a math-major guy ;-)
There was a problem hiding this comment.
Right, De Morgan's laws - and I did a thesis from fuzzy logic 🤦
There was a problem hiding this comment.
Ha, only now I know you also majored in math😄 My focus was random process and application in bio-stats.
But anyway, not rare for math people like us to miss OR/AND time to time😄
| @@ -95,7 +96,7 @@ def _import_helper(filepath): | |||
| fail_count += 1 | |||
| else: | |||
| suc_count += 1 | |||
| print("{} of {} variables successfully updated.".format(suc_count, len(var_json))) | |||
| print(f"{suc_count} of {len(var_json)} variables successfully updated.") | |||
There was a problem hiding this comment.
From other changes I had the impression that "removing following period" is one of the the points you are enforcing in this PR. Maybe you missed this one?
There was a problem hiding this comment.
I tried, but then I resigned because I'm not sure what's better:
some text and 6orsome text and 6.some 'text'=valueorsome 'text'=value.some /text/and/pathorsome /text/and/path.
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
|
I'm good with it 👍 |
This PR is a followup after #12375 and #12704 it improves handling
of some errors in cli commands to avoid show users to much traceback
and uses SystemExit consistently.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.