Use generic information in UpdateMask component #13146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The UpdateMask is used in connection, pools, variables and dag. So the docs should be more generic.
mik-laj
reviewed
Dec 18, 2020
| @@ -2784,8 +2784,8 @@ components: | |||
| items: | |||
| type: string | |||
| description: | | |||
| The fields to update on the connection (connection, pool etc). If absent or empty, all | |||
| modifiable fields are updated. A comma-separated list of fully qualified names of fields. | |||
| The fields to update on the object. If absent or empty, all modifiable fields are updated. | |||
There was a problem hiding this comment.
Object=>resource. What do you think?
mik-laj
approved these changes
Dec 18, 2020
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease. |
TobKed
approved these changes
Dec 18, 2020
kaxil
approved these changes
Dec 18, 2020
kaxil
pushed a commit
that referenced
this pull request
Jan 21, 2021
The UpdateMask is used in connection, pools, variables and dag. So the docs should be more generic. (cherry picked from commit c26366e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UpdateMask is used in connection, pools, variables and dag. So the docs should be more generic. Currently the connection reference in DAG patch is little strange:
https://airflow.apache.org/docs/apache-airflow/stable/stable-rest-api-ref.html?#operation/patch_dag
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.