Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 422 invalid value error caused by long k8s pod name #13299

Merged
merged 3 commits into from
Jan 29, 2021
Merged

fix 422 invalid value error caused by long k8s pod name #13299

merged 3 commits into from
Jan 29, 2021

Commits on Jan 20, 2021

  1. fix 422 invalid value error caused by long k8s pod name 

    K8S pod names follows DNS_SUBDOMAIN naming convention, which can be
broken down into one or more DNS_LABEL separated by `.`.

While the max length of pod name (DNS_SUBDOMAIN) is 253, each label
component (DNS_LABEL) of a the name cannot be longer than 63. Pod names
generated by k8s executor right now only contains one label, which means
the total effective name length cannot be greater than 63.

This patch concats uuid to pod_id using `.` to generate the pod anem,
thus extending the max name length to 63 + len(uuid).

Reference: https://github.com/kubernetes/kubernetes/blob/release-1.1/docs/design/identifiers.md
Relevant discussion: kubernetes/kubernetes#79351 (comment)
    Qingping Hou committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    6890444 View commit details
    Browse the repository at this point in the history

  2. address review feedback

    Qingping Hou committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    8bc9581 View commit details
    Browse the repository at this point in the history

  3. more label sanitizing for task_id, dag_id and scheduler_job_id

    Qingping Hou committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    9a5d55a View commit details
    Browse the repository at this point in the history