Check for minimum version of Sqlite #13496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some users testing Airlfow 2.0 with sqlite noticed that for old versions of sqlite, Airflow does not run tasks and fails with 'sqlite3.OperationalError: near ",": syntax error' when running tasks. More details about it in apache#13397. Bisecting had shown that minimum supported version of sqlite is 3.15.0, therefore this PR adds checking if sqlite version is higher than that and fails hard if it is not. Documentation has been updated with minimum requirements, some inconsisttencies have been removed, also the minimum requirements for stable 2.0 version were moved to installation.rst because the requirements were never explicitely stated in the user-facing documentation.
potiuk
force-pushed
the
add-sqlite3-limiations
branch
from
04bc345
to
ecd269c
Compare
kaxil
reviewed
Jan 5, 2021
kaxil
approved these changes
Jan 5, 2021
kaxil
pushed a commit
that referenced
this pull request
Jan 21, 2021
Some users testing Airlfow 2.0 with sqlite noticed that for old versions of sqlite, Airflow does not run tasks and fails with 'sqlite3.OperationalError: near ",": syntax error' when running tasks. More details about it in #13397. Bisecting had shown that minimum supported version of sqlite is 3.15.0, therefore this PR adds checking if sqlite version is higher than that and fails hard if it is not. Documentation has been updated with minimum requirements, some inconsisttencies have been removed, also the minimum requirements for stable 2.0 version were moved to installation.rst because the requirements were never explicitely stated in the user-facing documentation. (cherry picked from commit b213dbe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users testing Airlfow 2.0 with sqlite noticed that for
old versions of sqlite, Airflow does not run tasks and fails with
'sqlite3.OperationalError: near ",": syntax error' when running
tasks. More details about it in #13397.
Bisecting had shown that minimum supported version of sqlite is
3.15.0, therefore this PR adds checking if sqlite version is
higher than that and fails hard if it is not.
Documentation has been updated with minimum requirements, some
inconsisttencies have been removed, also the minimum requirements
for stable 2.0 version were moved to installation.rst because
the requirements were never explicitely stated in the user-facing
documentation.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.