Setting max_tis_per_query to 0 now correctly removes the limit
#13512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
area:Scheduler
ashb
added
full tests needed
kaxil
approved these changes
Jan 6, 2021
mik-laj
approved these changes
Jan 6, 2021
potiuk
approved these changes
Jan 6, 2021
|
The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason. |
kaxil
force-pushed
the
max-active-tis-per-query-0-fix
branch
from
8904308
to
0cb9c94
Compare
|
The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason. |
kaxil
force-pushed
the
max-active-tis-per-query-0-fix
branch
from
0cb9c94
to
67a07a9
Compare
|
The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason. |
kaxil
force-pushed
the
max-active-tis-per-query-0-fix
branch
from
67a07a9
to
cb1d97a
Compare
|
The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason. |
This config setting is documented as 0==unlimited, but in my HA scheduler work I rewrote the code that used this and mistakenly didn't keep this behaviour. This re-introduces the correct behaviour and also adds a test so that it is stays working in the future.
kaxil
force-pushed
the
max-active-tis-per-query-0-fix
branch
from
cb1d97a
to
53d0b1f
Compare
kaxil
force-pushed
the
max-active-tis-per-query-0-fix
branch
from
53d0b1f
to
93dc138
Compare
kaxil
pushed a commit
that referenced
this pull request
Jan 21, 2021
) This config setting is documented as 0==unlimited, but in my HA scheduler work I rewrote the code that used this and mistakenly didn't keep this behaviour. This re-introduces the correct behaviour and also adds a test so that it is stays working in the future. Co-authored-by: Kaxil Naik <[email protected]> (cherry picked from commit 31d31ad)
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 12, 2021
…che#13512) This config setting is documented as 0==unlimited, but in my HA scheduler work I rewrote the code that used this and mistakenly didn't keep this behaviour. This re-introduces the correct behaviour and also adds a test so that it is stays working in the future. Co-authored-by: Kaxil Naik <[email protected]> (cherry picked from commit 31d31ad) (cherry picked from commit 1a848e8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This config setting is documented as 0==unlimited, but in my HA
scheduler work I rewrote the code that used this and mistakenly didn't
keep this behaviour.
This re-introduces the correct behaviour and also adds a test so that it
is stays working in the future.
Fixes #13325
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.