Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support annotations for the flower service in the chart #13616

Conversation

FloChehab
Copy link
Contributor

Hello,

This is simple PR that adds the ability to add annotations
to the flower service in the chart.

Docs and tests updated accordingly.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

Simple commit that adds the ability to add annotations
to the flower service in the chart.

Docs and tests updated accordingly.
@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Jan 11, 2021
@FloChehab
Copy link
Contributor Author

Hello @mik-laj , this PR is good start towards what you were describing in #12010 (comment) .

@mik-laj
Copy link
Member

mik-laj commented Jan 11, 2021

I wonder if we should review all objects and standardize support for annotations. As you can see this annotation support is being added in several PRs for different objects, and I guess it won't be hard to do this for all objects. Are you interested in this?

@mik-laj mik-laj requested a review from XD-DENG January 11, 2021 21:53
@github-actions
Copy link

The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.

@FloChehab
Copy link
Contributor Author

I wonder if we should review all objects and standardize support for annotations. As you can see this annotation support is being added in several PRs for different objects, and I guess it won't be hard to do this for all objects. Are you interested in this?

Yeah I can look into that. Maybe we should create an issue for this so that we agree on the how (terminology, objects, location in the values.yaml) before starting the dev? Wdyt ?

@mik-laj
Copy link
Member

mik-laj commented Jan 12, 2021

@FloChehab the idea sounds good to me. the new issue allows us to discuss freely.

@FloChehab
Copy link
Contributor Author

Closing in favor of #13643.

@FloChehab FloChehab closed this Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants