BaseBranchOperator will push to xcom by default. #13763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will BaseBranchOperator to do xcom push of the branch it choose to follow. It will also add support to use the do_xcom_push parameter. The added change returns the result received by running choose_branch().
kaxil
reviewed
Jan 19, 2021
| self.skip_all_except(context['ti'], self.choose_branch(context)) | ||
| branches_to_execute = self.choose_branch(context) | ||
| self.skip_all_except(context['ti'], branches_to_execute) | ||
| return branches_to_execute |
There was a problem hiding this comment.
This means it will always push right, even if do_xcom_push is False
There was a problem hiding this comment.
Not sure about this. I dont think it would always push.
I did run the test case that I added for checking xcom push (Permalink to the test function) with do_xcom_push=False and the value returned by - ti.xcom_pull(task_ids='make_choice') was None
Have I understood the issue wrong? I followed PythonBranchOperator as a guide to figure out what was needed to be done.
There was a problem hiding this comment.
kaxil
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will allow BaseBranchOperator to xcom push the branch it chose to follow.
It will also add support to use the
do_xcom_pushparameter.The change includes the returning the result of
choose_branch()wheneverexecute()is called.Currently the BaseBranchOperator neither pushes the chosen branch to xcom nor support's the
do_xcom_pushparameter.Closes: #13704