Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DAGs mount path in Kubernetes worker pod when gitSync is enabled #13826

Merged
merged 3 commits into from
Feb 4, 2021
Merged

Fix DAGs mount path in Kubernetes worker pod when gitSync is enabled #13826

merged 3 commits into from
Feb 4, 2021

Conversation

varunvora
Copy link
Contributor

@varunvora varunvora commented Jan 22, 2021 •
edited
Loading

closes: #13680

The path to search for DAGs is incorrect in the new pod when gitSync is enabled. The error it causes currently is mentioned in the issue

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Jan 22, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 22, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@github-actions
Copy link

The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.

@varunvora varunvora mentioned this pull request Jan 26, 2021
Closed
@dnskr
Fix ssh-key access issue
03442a2 
This change allows dags.gitSync.containerName to read ssh-key from file system.
Similar to this https://github.com/varunvora/airflow/blob/ce0e6280d2ea39838e9f0617625cd07a757c3461/chart/templates/scheduler/scheduler-deployment.yaml#L92
It solves #13680 issue for private repositories.
@dnskr
Copy link
Contributor

dnskr commented Jan 28, 2021 •
edited
Loading

Hi @varunvora!
Please have a look this change: https://github.com/varunvora/airflow/pull/1#issue-563399608
Actually we have two reasons of the 13680 issue. Your fix + mine fix solved both.

@varunvora
Merge pull request #1 from dnskr/patch-1
ad6d213 
Fix ssh-key access issue
@varunvora
Copy link
Contributor Author

@potiuk can you review this?

potiuk
potiuk reviewed Jan 30, 2021
View reviewed changes
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be great to add some unit tests covering this cases - following the helm chart unit tests we have, also I think it would be great to have @dimberman take a look at those changes.

@dimberman dimberman self-requested a review February 4, 2021 19:01
@dimberman dimberman merged commit 5f74219 into apache:master Feb 4, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 4, 2021

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk potiuk left review comments

@dimberman dimberman dimberman approved these changes

Assignees
No one assigned
Labels
area:helm-chart Airflow Helm Chart
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"dag_id could not be found" when running airflow on KubernetesExecutor
4 participants
@varunvora @dnskr @potiuk @dimberman