Don't add User role perms to custom roles.

[jhtimmins]

Solves the problem of roles getting incorrectly populated with all permissions of the User class. Now they are auto-populated with Website.can_read and nothing else.

Expected Behavior

When a custom role is created, the role should not include any extra permissions beyond what the user added.

Actual Behavior

All permissions for the default User role are copied into each custom rule.

Update Behavior

Rather than adding all permissions from the User role, the only permission added now is Website.can_read. This is required to allow access to the homepage.

closes: #9245
related: #9245

[kaxil]

That was quick :) -- Can you please add PR description describing the change and reference the Github issue it solves?

[jhtimmins]

@kaxil My b, I thought I had added it. Updated!

[kaxil]

cc @davido912

[kaxil]

Thanks James, will take a deeper look over the weekend or Monday

This might fix #13511 too

[davido912]

I can confirm this does indeed fix the issue where a role would be populated with the USER permissions. I opened another issue that still remains. I've yet to find a fix for this but thanks for looking into this!
#13891

@kaxil @jhtimmins

[kaxil]

Thanks @jhtimmins for the PR and @davido912 for testing it :)

[kaxil]

I have started seeing this warnings @jhtimmins -- after merging this to Master and running Airflow locally with it:

[2021-01-25 15:01:35,448] {manager.py:549} WARNING - Refused to delete permission view, assoc with role exists Airflow.can_elasticsearch Admin
[2021-01-25 15:01:35,456] {manager.py:549} WARNING - Refused to delete permission view, assoc with role exists Airflow.can_pickle_info Admin
[2021-01-25 15:01:35,462] {manager.py:549} WARNING - Refused to delete permission view, assoc with role exists Airflow.can_elasticsearch Admin
[2021-01-25 15:01:35,469] {manager.py:549} WARNING - Refused to delete permission view, assoc with role exists Airflow.can_pickle_info Admin
[2021-01-25 15:01:35,628] {manager.py:549} WARNING - Refused to delete permission view, assoc with role exists Airflow.can_elasticsearch Admin
[2021-01-25 15:01:35,635] {manager.py:549} WARNING - Refused to delete permission view, assoc with role exists Airflow.can_pickle_info Admin
[2021-01-25 15:01:35,665] {manager.py:549} WARNING - Refused to delete permission view, assoc with role exists Airflow.can_elasticsearch Admin
[2021-01-25 15:01:35,673] {manager.py:549} WARNING - Refused to delete permission view, assoc with role exists Airflow.can_pickle_info Admin
[2021-01-25 15:01:56 +0000] [389] [INFO] Handling signal: winch