Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TaskNotFound in log endpoint #13872

Merged
merged 1 commit into from
Jan 24, 2021
Merged

Fix TaskNotFound in log endpoint #13872

merged 1 commit into from
Jan 24, 2021

Conversation

vemikhaylov
Copy link
Contributor

closes: #13843

@boring-cyborg boring-cyborg bot added the area:API Airflow's REST/HTTP API label Jan 24, 2021
@potiuk potiuk added this to the Airflow 2.0.1 milestone Jan 24, 2021
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Jan 24, 2021
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk potiuk merged commit dfbccd3 into apache:master Jan 24, 2021
@potiuk
Copy link
Member

potiuk commented Jan 24, 2021

Thanks @vemikhaylov !

@Lorenzo-N
Copy link

Thanks!

@vemikhaylov
Copy link
Contributor Author

@potiuk My pleasure :) Just wanted to clarify one thing for myself. I haven't found any handlers that use ti.task at the moment. Is it for the potential case if some of them will require it in the future? And it's a responsibility of the handler to check whether ti.task isn't None, right?

@vemikhaylov vemikhaylov deleted the bug/api-logs-task-no-found branch January 24, 2021 15:14
kaxil pushed a commit that referenced this pull request Jan 27, 2021
@vemikhaylov @kaxil
Fix TaskNotFound in log endpoint (#13872)
fefcb7c 
(cherry picked from commit dfbccd3)
kaxil pushed a commit that referenced this pull request Feb 4, 2021
@vemikhaylov @kaxil
Fix TaskNotFound in log endpoint (#13872)
e60ca11 
(cherry picked from commit dfbccd3)
kaxil pushed a commit to astronomer/airflow that referenced this pull request Apr 12, 2021
@vemikhaylov @kaxil
Fix TaskNotFound in log endpoint (apache#13872)
fedf636 
(cherry picked from commit dfbccd3)
(cherry picked from commit e60ca11)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk potiuk approved these changes

Assignees
No one assigned
Labels
area:API Airflow's REST/HTTP API okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Milestone
Airflow 2.0.1
Development

Successfully merging this pull request may close these issues.

Task not found exception in get logs api
3 participants
@vemikhaylov @potiuk @Lorenzo-N