Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added missing return parameter in read function of FileTaskHandler #14001

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

vikramcse
Copy link
Contributor

this issue occurs when invalid try_number value is passed in get logs api
FIXES: #13638

this issue ouccurs when invalid try_number value is passed in get logs api
FIXES: apache#13638
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 1, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@@ -207,7 +207,7 @@ def read(self, task_instance, try_number=None, metadata=None):
logs = [
[('default_host', f'Error fetching the logs. Try number {try_number} is invalid.')],
]
return logs
return logs, [{'end_of_log': True}]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is interesting because such error should be spotted by pylint as inconsistent return statement. I think this is yet another time when I have a feeling that our pylint may not work perfectly well. CC @kaxil @ashb @potiuk

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Feb 1, 2021
@github-actions
Copy link

github-actions bot commented Feb 1, 2021

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@vikramcse
Copy link
Contributor Author

@turbaszek what should be my next step? I can see the please reabse or ammed ci build is still running
thank you

@turbaszek turbaszek merged commit 2366f86 into apache:master Feb 1, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 1, 2021

Awesome work, congrats on your first merged pull request!

@kaxil kaxil added this to the Airflow 2.0.1 milestone Feb 1, 2021
kaxil pushed a commit that referenced this pull request Feb 1, 2021
…14001)

this issue ouccurs when invalid try_number value is passed in get logs api
FIXES: #13638

(cherry picked from commit 2366f86)
kaxil pushed a commit that referenced this pull request Feb 4, 2021
…14001)

this issue ouccurs when invalid try_number value is passed in get logs api
FIXES: #13638

(cherry picked from commit 2366f86)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:logging full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stable API task logs
3 participants