-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added missing return parameter in read function of FileTaskHandler #14001
Conversation
this issue ouccurs when invalid try_number value is passed in get logs api FIXES: apache#13638
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
@@ -207,7 +207,7 @@ def read(self, task_instance, try_number=None, metadata=None): | |||
logs = [ | |||
[('default_host', f'Error fetching the logs. Try number {try_number} is invalid.')], | |||
] | |||
return logs | |||
return logs, [{'end_of_log': True}] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
@turbaszek what should be my next step? I can see the |
Awesome work, congrats on your first merged pull request! |
this issue occurs when invalid try_number value is passed in get logs api
FIXES: #13638