Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry critical methods in Scheduler loop in case of OperationalError #14032

Merged
merged 1 commit into from
Feb 4, 2021

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Feb 2, 2021

Review without whitespace changes: https://github.com/apache/airflow/pull/14032/files?diff=split&w=1

In the case of OperationalError (caused deadlocks, network blips), the scheduler will now retry those methods 3 times.

closes #11899
closes #13668


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added the area:Scheduler including HA (high availability) scheduler label Feb 2, 2021
@kaxil kaxil marked this pull request as ready for review February 3, 2021 03:09
@kaxil kaxil changed the title Retry transactions for critical parts of Scheduler loops Retry transactions for critical parts of Scheduler loop Feb 3, 2021
@kaxil kaxil changed the title Retry transactions for critical parts of Scheduler loop Retry critical methods in Scheduler loop in case of Deadlocks Feb 3, 2021
@kaxil kaxil changed the title Retry critical methods in Scheduler loop in case of Deadlocks Retry critical methods in Scheduler loop in case of errors Feb 3, 2021
@kaxil kaxil changed the title Retry critical methods in Scheduler loop in case of errors Retry critical methods in Scheduler loop in case of deadlocks Feb 3, 2021
@kaxil kaxil changed the title Retry critical methods in Scheduler loop in case of deadlocks Retry critical methods in Scheduler loop in case of OperationalError Feb 3, 2021
@github-actions
Copy link

github-actions bot commented Feb 3, 2021

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@kaxil
Copy link
Member Author

kaxil commented Feb 4, 2021

Tests are passing

@github-actions
Copy link

github-actions bot commented Feb 4, 2021

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Feb 4, 2021
@kaxil kaxil merged commit 914e9ce into apache:master Feb 4, 2021
@kaxil kaxil deleted the retry-adoption branch February 4, 2021 01:31
kaxil added a commit that referenced this pull request Feb 4, 2021
…14032)

In the case of OperationalError (caused deadlocks, network blips), the scheduler will now retry those methods 3 times.

closes #11899
closes #13668

(cherry picked from commit 914e9ce)
kaxil added a commit that referenced this pull request Feb 4, 2021
…14032)

In the case of OperationalError (caused deadlocks, network blips), the scheduler will now retry those methods 3 times.

closes #11899
closes #13668

(cherry picked from commit 914e9ce)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Scheduler including HA (high availability) scheduler full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
2 participants