Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up clear_task_instances by doing a single sql delete for TaskReschedule #14048

Merged
merged 9 commits into from
Feb 10, 2021
Merged

Speed up clear_task_instances by doing a single sql delete for TaskReschedule #14048

merged 9 commits into from
Feb 10, 2021

Commits on Feb 8, 2021

  1. Speed up clear_task_instances by doing a bulk delete

    @yuqian90
    yuqian90 committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    8c2f9b4 View commit details
    Browse the repository at this point in the history

  2. Only delete if there are matches

    @yuqian90
    yuqian90 committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    36f46d8 View commit details
    Browse the repository at this point in the history

  3. Try TR.__table__.delete()

    @yuqian90
    yuqian90 committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    7d23b94 View commit details
    Browse the repository at this point in the history

  4. Optimization for the case when all tis are for the samd dag_id

    @yuqian90
    yuqian90 committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    49b04b9 View commit details
    Browse the repository at this point in the history

  5. Add test_clear_task_instances_with_task_reschedule

    @yuqian90
    yuqian90 committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    2b206b6 View commit details
    Browse the repository at this point in the history

  6. Revert "Optimization for the case when all tis are for the samd dag_id" 

    This reverts commit c6d4f301e622858053e52bac27e799841f1c68eb.
    @yuqian90
    yuqian90 committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    772b699 View commit details
    Browse the repository at this point in the history

  7. Review suggestions

    @kaxil @yuqian90
    kaxil authored and yuqian90 committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    36e7270 View commit details
    Browse the repository at this point in the history

  8. Group filters by dag_id execution_date and try_number 

    clear_task_instances took 2.240063190460205
    @yuqian90
    yuqian90 committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    6b67c43 View commit details
    Browse the repository at this point in the history

  9. Get rid of redundant loop

    @yuqian90
    yuqian90 committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    3b262b5 View commit details
    Browse the repository at this point in the history