Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small docs readme update #14062

Merged
merged 3 commits into from
Feb 4, 2021
Merged

Conversation

leahecole
Copy link
Contributor

Added a small update to the docs README after I found running docs locally to not be intuitive (building instructions are great though!! 😄 ) (thanks @rachael-ds for rescuing me)

@github-actions
Copy link

github-actions bot commented Feb 4, 2021

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a change to fix failing static check

docs/README.rst Outdated Show resolved Hide resolved
Co-authored-by: Kaxil Naik <[email protected]>
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Feb 4, 2021
@github-actions
Copy link

github-actions bot commented Feb 4, 2021

The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@leahecole leahecole merged commit f6cfc41 into apache:master Feb 4, 2021
@leahecole leahecole deleted the docs-readme-update branch February 4, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:documentation okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants