Refactor redundant doc url logic to use utility #14080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
approved these changes
Feb 4, 2021
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
ryanahamilton
force-pushed
the
doc_link_refactor
branch
from
55deb18
to
85633ad
Compare
turbaszek
approved these changes
Feb 5, 2021
|
The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason. |
ryanahamilton
force-pushed
the
doc_link_refactor
branch
2 times, most recently
from
b95f654
to
c81ee9b
Compare
ryanahamilton
force-pushed
the
doc_link_refactor
branch
from
c81ee9b
to
573ef53
Compare
|
Repeated CI failures appear unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API exceptions had redundant logic to generate versioned documentation URLs instead of using the
get_docs_urlutility method. I also tweaked the condition to also capturea/b(alpha/beta) suffixes.