Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates example/docs related to overriding the pod_template_file to m… #14199

Conversation

DerekHeldtWerle
Copy link
Contributor

When the option was originally added to allow for users to override the pod_template_file on a per-task basis via the executor_config, there were never docs added that mentioned the proper way to override the pod_template_file. This PR updates the example to now include a note to use pod_template_override as mentions the need for setting it in the documentation.

@boring-cyborg boring-cyborg bot added provider:cncf-kubernetes Kubernetes provider related issues kind:documentation labels Feb 11, 2021
@eladkal eladkal requested review from dimberman and kaxil March 27, 2021 06:29
@kaxil kaxil closed this in #15197 Apr 5, 2021
kaxil added a commit that referenced this pull request Apr 5, 2021
)

This feature was added in #11784 but
it was broken as it got `pod_template_override` from `executor_config`
instead of `pod_template_file`.

closes #14199
kaxil added a commit that referenced this pull request Apr 9, 2021
)

This feature was added in #11784 but
it was broken as it got `pod_template_override` from `executor_config`
instead of `pod_template_file`.

closes #14199

(cherry picked from commit 5606137)
kaxil added a commit to astronomer/airflow that referenced this pull request Apr 12, 2021
…che#15197)

This feature was added in apache#11784 but
it was broken as it got `pod_template_override` from `executor_config`
instead of `pod_template_file`.

closes apache#14199

(cherry picked from commit 5606137)
(cherry picked from commit 091fae90a0a564e2da92ead7dd5be2c1e8b56301)
ashb pushed a commit that referenced this pull request Apr 15, 2021
)

This feature was added in #11784 but
it was broken as it got `pod_template_override` from `executor_config`
instead of `pod_template_file`.

closes #14199

(cherry picked from commit 5606137)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:documentation provider:cncf-kubernetes Kubernetes provider related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant