Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Js linting and inline migration for simple scripts #14215

Merged
merged 6 commits into from
Feb 16, 2021
Merged

Js linting and inline migration for simple scripts #14215

merged 6 commits into from
Feb 16, 2021

Conversation

bbovenzi
Copy link
Contributor

  • Moved simple inline js to its own file with linting as per Migrate inline JavaScript scripting to external files #14115, other more complicated files will be their own PRs (gantt, graph, tree, dag, dags)
  • Replaced jQuery some deprecated functions
  • changed all js files to snake_case instead of kebab-case for consistency's sake

@bbovenzi
Js linting and inline migration for simple scripts
774b776 
- Linting for all the relatively simple JS in our html templates
- Replaced jQuery .click() and .ready() functions
- changed all js files to snake_case instead of kebab-case for consistency
@boring-cyborg boring-cyborg bot added area:dev-tools area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Feb 12, 2021
ashb
ashb requested changes Feb 15, 2021
View reviewed changes
Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small changes.

ryanahamilton
ryanahamilton requested changes Feb 15, 2021
View reviewed changes
Copy link
Contributor

@ryanahamilton ryanahamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much appreciated work, thank you @bbovenzi!

airflow/www/templates/airflow/dag_code.html Outdated Show resolved Hide resolved
@bbovenzi
Copy link
Contributor Author

@ryanahamilton @ashb Added the requested changes.

@ashb
Copy link
Member

ashb commented Feb 16, 2021

Looks good now @bbovenzi -- conflicts to resolve though.

@ryanahamilton ryanahamilton merged commit 9f14724 into apache:master Feb 16, 2021
@ryanahamilton ryanahamilton deleted the js-linting branch February 16, 2021 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mik-laj mik-laj mik-laj left review comments

@ashb ashb ashb approved these changes

@ryanahamilton ryanahamilton ryanahamilton approved these changes

Assignees
No one assigned
Labels
area:dev-tools area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bbovenzi @ashb @ryanahamilton @mik-laj