Fix minor issues in 'Concepts' doc #14679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XD-DENG
added
area:docs
kind:documentation
changelog:skip
XD-DENG
commented
Mar 9, 2021
| @@ -1641,7 +1641,7 @@ A ``.airflowignore`` file specifies the directories or files in ``DAG_FOLDER`` | |||
| or ``PLUGINS_FOLDER`` that Airflow should intentionally ignore. | |||
| Each line in ``.airflowignore`` specifies a regular expression pattern, | |||
| and directories or files whose names (not DAG id) match any of the patterns | |||
| would be ignored (under the hood,``Pattern.search()`` is used to match the pattern). | |||
There was a problem hiding this comment.
Currently this is not rendered properly.
XD-DENG
commented
Mar 9, 2021
| @@ -134,7 +134,7 @@ any of its operators. This makes it easy to apply a common parameter to many ope | |||
|
|
|||
| dag = DAG('my_dag', default_args=default_args) | |||
| op = DummyOperator(task_id='dummy', dag=dag) | |||
| print(op.owner) # Airflow | |||
| print(op.owner) # airflow | |||
There was a problem hiding this comment.
To be consistent with the value above.
kaxil
approved these changes
Mar 9, 2021
github-actions
bot
added
the
okay to merge
|
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease. |
ashb
pushed a commit
that referenced
this pull request
Mar 19, 2021
(cherry picked from commit 99aab05)
ashb
pushed a commit
that referenced
this pull request
Apr 15, 2021
(cherry picked from commit 99aab05)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading through the doc and found some issues in
Conceptsdoc page.Some clarifications will be added in-line below.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.