Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure we use ti.queued_by_job_id #14795

Merged
merged 3 commits into from
Apr 26, 2021
Merged

Ensure we use ti.queued_by_job_id #14795

merged 3 commits into from
Apr 26, 2021

Commits on Apr 26, 2021

  1. Ensure we use ti.queued_by_job_id 

    Ensure that we use ti.queued_by_job_id when searching for pods. The queued_by_job_id is used by
adopt_launched_task when updating the labels. Without this, after restarting the scheduler
a third time, the scheduler does not find the pods as it is still searching for the id of
the original scheduler (ti.external_executor_id)

Co-Authored-By: samwedge <[email protected]>
Co-Authored-By: philip-hope <[email protected]>
    @atrbgithub @samwedge @philip-hope
    3 people committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    da7dc8c View commit details
    Browse the repository at this point in the history

  2. Only try to adopt from a scheduler_job_id once

    @jedcunningham @atrbgithub
    jedcunningham authored and atrbgithub committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    838ecb4 View commit details
    Browse the repository at this point in the history

  3. Add test coverage for KubernetesExecutor.test_try_adopt_task_instances

    @jedcunningham @atrbgithub
    jedcunningham authored and atrbgithub committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    d5493df View commit details
    Browse the repository at this point in the history