Fix KubernetesExecutor issue with deleted pending pods #14810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change treats a pending KubernetesExecutor worker pod deletion as a failure. This allows them to follow the configured retry rules for the task as one would expect.
jedcunningham
requested review from
ashb,
kaxil,
turbaszek and
XD-DENG
as code owners
boring-cyborg
bot
added
provider:cncf-kubernetes
kaxil
approved these changes
Mar 15, 2021
ashb
pushed a commit
that referenced
this pull request
Mar 19, 2021
This change treats a pending KubernetesExecutor worker pod deletion as a failure. This allows them to follow the configured retry rules for the task as one would expect. (cherry picked from commit a639dd3)
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 12, 2021
This change treats a pending KubernetesExecutor worker pod deletion as a failure. This allows them to follow the configured retry rules for the task as one would expect. (cherry picked from commit a639dd3)
ashb
pushed a commit
that referenced
this pull request
Apr 15, 2021
This change treats a pending KubernetesExecutor worker pod deletion as a failure. This allows them to follow the configured retry rules for the task as one would expect. (cherry picked from commit a639dd3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14556
This change treats a pending KubernetesExecutor worker pod deletion
as a failure. This allows them to follow the configured retry rules
for the task as one would expect.