Add different modes to sort dag files for parsing #15046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
area:Scheduler
ashb
reviewed
Mar 27, 2021
airflow/utils/dag_processing.py
Outdated
| # Sort the file paths by the parsing order mode | ||
| list_mode = conf.get("scheduler", "file_parsing_sort_mode", fallback="modified_time") | ||
|
|
||
| if list_mode not in FILE_PARSER_MODES: |
There was a problem hiding this comment.
This should be in configuration.py's validate method
jedcunningham
approved these changes
Mar 27, 2021
ashb
reviewed
Mar 29, 2021
airflow/config_templates/config.yml
Outdated
| parse different DAG files. | ||
| * ``alphabetical``: Sort by filename | ||
|
|
||
| version_added: 2.0.2 |
There was a problem hiding this comment.
Shouldn't this be 2.1? It feels like a new feature, not a bug fix to me
ashb
reviewed
Mar 29, 2021
airflow/configuration.py
Outdated
| if list_mode not in file_parser_modes: | ||
| raise AirflowConfigException( | ||
| "`[scheduler] file_parsing_sort_mode` should not be " | ||
| + list_mode |
There was a problem hiding this comment.
Suggested change
| + list_mode | |
| + repr(list_mode) |
There was a problem hiding this comment.
Use an f-string too maybe for this whole lote?
ashb
reviewed
Mar 29, 2021
kaxil
force-pushed
the
add-dag-processing-modes
branch
from
91cdd08
to
e394feb
Compare
ashb
reviewed
Mar 29, 2021
ashb
approved these changes
Mar 29, 2021
kaxil
force-pushed
the
add-dag-processing-modes
branch
from
d1179db
to
fe3f40b
Compare
This commit adds the feature to allow users to set one of the following modes, the scheduler will list and sort the dag files to decide the parsing order.: - `modified_time`: Sort by modified time of the files. This is useful on large scale to parse the recently modified DAGs first. - `random_seeded_by_host`: Sort randomly across multiple Schedulers but with same order on the same host. This is useful when running with Scheduler in HA mode where each scheduler can parse different DAG files. - `alphabetical`: Sort by filename
kaxil
force-pushed
the
add-dag-processing-modes
branch
from
fe3f40b
to
31f5947
Compare
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Apr 12, 2021
This commit adds the feature to allow users to set one of the following modes, the scheduler will list and sort the dag files to decide the parsing order.: - `modified_time`: Sort by modified time of the files. This is useful on large scale to parse the recently modified DAGs first. - `random_seeded_by_host`: Sort randomly across multiple Schedulers but with same order on the same host. This is useful when running with Scheduler in HA mode where each scheduler can parse different DAG files. - `alphabetical`: Sort by filename (cherry picked from commit 2e3eb42)
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Apr 26, 2021
This commit adds the feature to allow users to set one of the following modes, the scheduler will list and sort the dag files to decide the parsing order.: - `modified_time`: Sort by modified time of the files. This is useful on large scale to parse the recently modified DAGs first. - `random_seeded_by_host`: Sort randomly across multiple Schedulers but with same order on the same host. This is useful when running with Scheduler in HA mode where each scheduler can parse different DAG files. - `alphabetical`: Sort by filename (cherry picked from commit 2e3eb42)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the feature to allow users to set one of the following modes, the
scheduler will list and sort the dag files to decide the parsing order.:
modified_time: Sort by modified time of the files. This is useful on large scale to parse the recently modified DAGs first.random_seeded_by_host: Sort randomly across multiple Schedulers but with same order on the same host. This is useful when running with Scheduler in HA mode where each scheduler can parse different DAG files.alphabetical: Sort by filename^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.